Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update addButtonTo.js #676

Open
wants to merge 1 commit into
base: v6
Choose a base branch
from
Open

Update addButtonTo.js #676

wants to merge 1 commit into from

Conversation

supremesupreme
Copy link
Collaborator

Description

Emoji is acutally optional now

Fixes # (issue number / remove this line if no issue is to be referenced)

Type of change

Please check options that describe your Pull Request:

  • Bug fix (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

  • My code follows the style guidelines of this project
  • Any dependent changes have been merged and published in downstream modules

@@ -23,8 +23,7 @@ module.exports = async (d) => {

if (!style || style > 6 || style < 1) return d.aoiError.fnError(d, "custom", { inside: data.inside }, "Invalid Button Style Provided In");

emoji = await d.util.getEmoji(d, emoji.addBrackets()).id;
if (!emoji) emoji = emoji.addBrackets().trim();
emoji ? await d.util.getEmoji(d, emoji.addBrackets()).id : undefined
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaks unicode emojis

@Faf4a
Copy link
Member

Faf4a commented Nov 19, 2024

cc: @supremesupreme resolve requested changes

@Faf4a Faf4a added state: blocked PR needs changes before further review aoi.js this issue/Pr is related to aoi.js labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aoi.js this issue/Pr is related to aoi.js state: blocked PR needs changes before further review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants